D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation

Méven Car noreply at phabricator.kde.org
Fri May 15 15:55:35 BST 2020


meven added inline comments.

INLINE COMMENTS

> apol wrote in service_utils.h:45
> move implementations to service_utils.cpp?

I tried to do it, but I encountered errors.
Unless I am mistaken it is because this static function is shared with effects and effects are compiled to a separate shared lib.
So I would need to make a new build target for this one file to be able to share it with KWin::Core unless copied in both binaries.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29407

To: meven, #kwin, apol, davidedmundson, bport, zzag
Cc: ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200515/d5fdfbb7/attachment-0001.htm>


More information about the kwin mailing list