D29772: Don't compare string with empty string
Ismael Asensio
noreply at phabricator.kde.org
Fri May 15 15:51:23 BST 2020
iasensio added a comment.
All the changes seem nice but this one. I've not yet figure out why
INLINE COMMENTS
> FileDialogLoader.qml:49
> root.lastFolder = folder;
> - if (fileUrl != "") {
> + if (!fileUrl) {
> root.fileSelected(fileUrl);
This seems to break importing files for me.
Checking `lenght > 0` also didn't work, just old `if (fileUrl != "")`.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D29772
To: ognarb, #plasma, iasensio
Cc: broulik, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200515/5d0e6c9a/attachment.htm>
More information about the kwin
mailing list