D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri May 15 15:15:39 BST 2020


apol added a comment.


  Patch looks good to me overall.

INLINE COMMENTS

> service_utils.h:45
> +
> +static QStringList fetchProcessServiceField(const QString &executablePath, const QString &fieldName)
> +{

move implementations to service_utils.cpp?

> service_utils.h:66
> +
> +static QStringList fetchRequestedInterfaces(const QString &executablePath)
> +{

fetchRequestedWaylandInterfaces?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29407

To: meven, #kwin, apol, davidedmundson, bport, zzag
Cc: ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200515/d6a55bbe/attachment-0001.htm>


More information about the kwin mailing list