D29764: [kcm/kwinrules] Fix size properties not being stored

Vlad Zahorodnii noreply at phabricator.kde.org
Fri May 15 06:48:43 BST 2020


zzag added subscribers: yurchor, ltoscano, zzag.
zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  @ltoscano @yurchor Would it be okay to push this change to Plasma/5.19?

INLINE COMMENTS

> RulesEditor.qml:216
> +            case RuleItem.Size:
> +                return i18nc("Coordinates (x, y)", "(%1, %2)", value.width, value.height);
>              case RuleItem.Option:

The context says "coordinates", but I think it needs to say "size (width, height)".

REPOSITORY
  R108 KWin

BRANCH
  fixrulescoord

REVISION DETAIL
  https://phabricator.kde.org/D29764

To: iasensio, ngraham, #kwin, #plasma, zzag
Cc: zzag, ltoscano, yurchor, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200515/85d7a5ab/attachment-0001.htm>


More information about the kwin mailing list