D29685: Grant keyboard focus to popups on popup

Carson Black noreply at phabricator.kde.org
Tue May 12 18:28:37 BST 2020


cblack created this revision.
cblack added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
cblack requested review of this revision.

REVISION SUMMARY
  This grants the keyboard focus to popups; fixing oddities with popups from the shell being unable to grab keyboard focus. This utilises the same approach as what Mutter does for popups in GNOME, resulting in expected behaviour: granting keyboard focus to a popup on its creation.

TEST PLAN
  Before: popups from panels cannot focus.
  After: popups from panels can focus.

REPOSITORY
  R108 KWin

BRANCH
  cblack/grant-keyboard-to-popups (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29685

AFFECTED FILES
  keyboard_input.cpp
  xdgshellclient.cpp

To: cblack, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200512/93a0e2a4/attachment-0001.htm>


More information about the kwin mailing list