D29665: Emit Workspace::clientAdded() with AbstractClient

Vlad Zahorodnii noreply at phabricator.kde.org
Mon May 11 19:06:57 BST 2020


zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  Currently, if one wants to monitor for new X11 and Wayland clients, they
  have to listen for two signals. Workspace::clientAdded() is emitted only
  for X11 and Xwayland clients, while WaylandServer::shellClientAdded() is
  emitted only for xdg-shell clients. Such design doesn't scale well.
  
  As the first towards emitting Workspace::clientAdded() for new Wayland
  clients, this change replaces the X11Client parameter in the clientAdded
  signal with AbstractClient.

TEST PLAN
  Tests still pass.

REPOSITORY
  R108 KWin

BRANCH
  generic-client-added-signal

REVISION DETAIL
  https://phabricator.kde.org/D29665

AFFECTED FILES
  debug_console.cpp
  effects.cpp
  scripting/workspace_wrapper.cpp
  scripting/workspace_wrapper.h
  workspace.h

To: zzag, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200511/6324b9cc/attachment.htm>


More information about the kwin mailing list