D29459: scripting: Make client.activities writable

[Tiago Corrêa]

tcorreabr added inline comments.

INLINE COMMENTS

> zzag wrote in abstract_client.h:888
> It's already declared in the Toplevel class, remove it?

Initially I had tried without it, but I got this compilation error:

  [ 48%] Building CXX object CMakeFiles/kwin.dir/kwin_autogen/mocs_compilation.cpp.o
  In file included from /home/tiago/kde/build/kwin/kwin_autogen/mocs_compilation.cpp:2:
  /home/tiago/kde/build/kwin/kwin_autogen/EWIEGA46WW/moc_abstract_client.cpp: In function ‘void checkNotifySignalValidity_KWin__AbstractClient(KWin::AbstractClient*)’:
  /home/tiago/kde/build/kwin/kwin_autogen/EWIEGA46WW/moc_abstract_client.cpp:1155:26: error: no matching function for call to ‘KWin::AbstractClient::activitiesChanged()’
   1155 |     t->activitiesChanged();
        |                          ^
  In file included from /home/tiago/kde/src/kwin/abstract_client.h:24,
                   from /home/tiago/kde/build/kwin/kwin_autogen/EWIEGA46WW/moc_abstract_client.cpp:10,
                   from /home/tiago/kde/build/kwin/kwin_autogen/mocs_compilation.cpp:2:
  /home/tiago/kde/src/kwin/toplevel.h:610:10: note: candidate: ‘void KWin::Toplevel::activitiesChanged(KWin::Toplevel*)’
    610 |     void activitiesChanged(KWin::Toplevel* toplevel);
        |          ^~~~~~~~~~~~~~~~~
  /home/tiago/kde/src/kwin/toplevel.h:610:10: note:   candidate expects 1 argument, 0 provided
  [ 48%] Linking CXX executable ../bin/testScriptedEffectLoader

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29459

To: tcorreabr, #kwin, zzag
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200510/bbdeb93f/attachment-0001.htm>