D29486: xdgshellclient: Allow menus from panels to take focus

[Carson Black]

cblack added a comment.


  In D29486#665820 <https://phabricator.kde.org/D29486#665820>, @zzag wrote:
  
  > In D29486#665652 <https://phabricator.kde.org/D29486#665652>, @cblack wrote:
  >
  > > So this is a Qt bug where it's not requesting keyboard focus or a KWin bug where it's not granting keyboard focus?
  >
  >
  > It's our bug because popup grabs are implemented partially in kwayland-server.
  >
  > In D29486#665433 <https://phabricator.kde.org/D29486#665433>, @davidedmundson wrote:
  >
  > > I don't follow what you're referring to.
  > >
  > > We have XdgShellInterface::popupGrabRequested mapped correctly. Tooltips and menus are correctly differentiated.
  > >  We don't check the seat and serial properly, but if anything that means we're more likely to acknowledge a grab.
  >
  >
  > In order to ensure that the topmost grabbing popup has keyboard focus, we need a mechanism for grabbing input devices in kwayland-server.
  
  
  So if I wanted to properly fix this issue this patch works around, I would…
  
  1. Implement input device grabbing APIs in `kwayland-server`
  2. Have KWin use the new APIs introduced in 1 to grant the topmost grabbing popup keyboard focus
  
  Do I have that correct?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29486

To: cblack, #kwin, zzag
Cc: anthonyfieroni, zzag, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200508/b4afa4cc/attachment.htm>