D29486: xdgshellclient: Allow menus from panels to take focus

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> xdgshellclient.cpp:1015-1021
> +    if (isPopupMenu() || isPopupWindow()) {
> +        auto possiblyAPanel = qobject_cast<const XdgShellClient*>(transientFor());
> +        if (possiblyAPanel && possiblyAPanel->m_plasmaShellSurface) {
> +            return true;
> +        }
> +        return false;
> +    }

Should be just

  if (m_xdgShellPopup) {
      return true;
  }

?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29486

To: cblack, #kwin, zzag
Cc: anthonyfieroni, zzag, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200507/1c991bdf/attachment-0001.htm>