D29473: [kcmkwin/kwindecoration] Don't exec() QDialog

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> previewbridge.cpp:33-41
> +#include <QQuickItem>
> +#include <QQuickWindow>
>  #include <QDebug>
>  #include <QDBusConnection>
>  #include <QDBusMessage>
>  #include <QDialog>
>  #include <QDialogButtonBox>

Why are QQuick includes separated?

> previewbridge.cpp:237
> +        dialog->winId(); // so it creates windowHandle
> +        dialog->windowHandle()->setTransientParent(QQuickRenderControl::renderWindowFor(ctx->window()));
> +        dialog->setModal(true);

Have we come to the conclusion whether we should use QQuickRenderControl::renderWindowFor in KCMs? If so, could you please point me to the discussion?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29473

To: broulik, #kwin, davidedmundson
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200506/f9331a2f/attachment.html>