D29458: workspace.currentActivity write access

Vlad Zahorodnii noreply at phabricator.kde.org
Wed May 6 07:54:51 BST 2020


zzag added inline comments.

INLINE COMMENTS

> workspace_wrapper.cpp:123
> +#else
> +    Q_UNUSED(activity);
> +#endif

Could you please remove the semicolon. The Q_UNUSED macro is defined as `#define Q_UNUSED(x) (void)x;` so you don't need to put semicolon and I think Qt Creator will print a warning.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29458

To: tcorreabr, #kwin
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200506/be668fd5/attachment-0001.html>


More information about the kwin mailing list