D29443: KCM KWinVirtualDesktops disable UI when settings are immutable

Vlad Zahorodnii noreply at phabricator.kde.org
Tue May 5 15:50:06 BST 2020


zzag added inline comments.

INLINE COMMENTS

> animationsmodel.h:34
>      Q_PROPERTY(bool currentConfigurable READ currentConfigurable NOTIFY currentConfigurableChanged)
> +    Q_PROPERTY(bool isImmutable READ isImmutable WRITE setIsImmutable NOTIFY isImmutableChanged)
>  

I feel like this property belongs in EffectsModel.

> animationsmodel.h:60
>      void currentConfigurableChanged();
> +    void isImmutableChanged(bool isImmutable);
>  

s/isImmutableChanged/immutableChanged/

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29443

To: crossi, bport, meven, zzag, mart, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200505/2afe1db0/attachment.html>


More information about the kwin mailing list