D29443: KCM KWinVirtualDesktops disable UI when settings are immutable

Méven Car noreply at phabricator.kde.org
Tue May 5 11:32:51 BST 2020


meven accepted this revision.
meven added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:89
>              Kirigami.Action {
> -                enabled: !model.IsMissing
> +                enabled: !!model && !model.IsMissing && !kcm.isNumberImmutable
>                  iconName: "edit-delete-remove"

Is it really necessary to have `!!` ?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29443

To: crossi, bport, meven, zzag, mart, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200505/dd784c09/attachment.html>


More information about the kwin mailing list