D29423: [kcm/kwinrules] Fix layout misalignment of list items

[Ismael Asensio]

iasensio added a comment.


  In D29423#663384 <https://phabricator.kde.org/D29423#663384>, @ngraham wrote:
  
  > In the After views, there appear to be extra/excessive left and right margins compared the the Before images, which look more correct to me.
  
  
  There are more margins indeed. The `anchor` was also taking the margins from the `RowLayout` itself (only sometimes, hence the visual bug before)
  
  On the left side (a `Kirigami.Icon`), I introduced extra margins to compensate. This is how it looks without them:
  F8284448: overlay_remove_margins.png <https://phabricator.kde.org/F8284448>
  
  On the right side, there's a `QQC2.Button`, and what it seems to be a 1px extra margin to the right
  F8284457: overalay_gammaray_delegate.png <https://phabricator.kde.org/F8284457>
  
  That, and the button being only visible on hover makes the right part look more empty, so I though of keeping the extra margins on the left icon too.
  F8284470: Screenshot_20200504_212824.png <https://phabricator.kde.org/F8284470>
  
  I could also add negative margins on the right button (maybe too hackish?):
  F8284473: overlay_neg_margin.png <https://phabricator.kde.org/F8284473>

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29423

To: iasensio, broulik, #vdg, #kwin
Cc: ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200504/c1a3631d/attachment.html>