D27988: KCM/Compositing: Use KConfig XT in UI

Kevin Ottens noreply at phabricator.kde.org
Fri Mar 27 17:54:36 GMT 2020


ervin accepted this revision.
ervin added inline comments.

INLINE COMMENTS

> main.cpp:57
> +    void onBackendChanged();
> +    void reenableGl();
> +

That one was oddly fine (yes, Qt is inconsistent with dealing with GL and we are as well ;-))

> main.cpp:222
> +    changed |= backend != m_backend;
> +    changed |= m_animationDurationFactor != animationDuration;
> +    emit unmanagedWidgetChangeState(changed);

Ah, not what I had in mind since I would have liked to keep the const but no big deal

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27988

To: meven, #kwin, ervin, crossi, bport, hchain
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200327/d5f72717/attachment-0001.html>


More information about the kwin mailing list