D28310: Wayland: Allow to set a scroll Factor for input devices

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> device.cpp:315
>          readEntry(key, it.value().stringSetter, "");
> +        readEntry(key, it.value().qrealSetter, 1);
>      };

There is type erasure and implicit conversion involved so I guess it ends up working properly in practice, still I'd advise using "1.0" here which would be of the right type. Just a question of making intent obvious.

> device.h:335
>  
> +    qreal ScrollFactorDefault() const {
> +        return 1.0;

s/ScrollFactorDefault/scrollFactorDefault/

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28310

To: meven, #kwin, davidedmundson, zzag, bport, ervin, apol
Cc: apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200327/f5034976/attachment.html>