D28283: Remove overloads on virtual methods
Vlad Zahorodnii
noreply at phabricator.kde.org
Thu Mar 26 08:06:35 GMT 2020
zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> abstract_client.cpp:713
> if (area.width() < width() || area.height() < height())
> - resizeWithChecks(qMin(area.width(), width()), qMin(area.height(), height()));
> + resizeWithChecks(area.size().boundedTo(size()));
> }
I'd swap `size()` and `area.size()` so when the code is read by someone it's easier to understand what we do.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28283
To: apol, #kwin, zzag
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200326/478a8b01/attachment.html>
More information about the kwin
mailing list