D28230: [wayland] Add new XdgOutput properties

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in abstract_wayland_output.cpp:284
> I had looked. Without bringing in further behavioural changes it makes things worse.
> 
> You then need to change screens to be in sync, and that one gets used a lot.
> 
> Then instead of having one piece of code refer to name when they mean description, we have dozens refer to description when they just want a simple readable name.

So, I assume you're talking about output mapping for touch devices. If that's the case, we could set the udev 'WL_OUTPUT` property on the input device, but nobody does it. Alternatively, we could follow libinput's documentation [1] and use something else.

My main concern about this code is that we start mixing identifiers, names, and descriptions, which makes code more difficult to work with and reason about.

[1] https://wayland.freedesktop.org/libinput/doc/latest/api/group__device.html#gaf48626f6190e9c9bc14abb704e66cc22

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28230

To: davidedmundson, #kwin, #plasma
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200324/adb305e2/attachment.html>