D28230: [wayland] Add new XdgOutput properties

David Edmundson noreply at phabricator.kde.org
Tue Mar 24 08:57:38 GMT 2020


davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in abstract_wayland_output.cpp:284
> Please rename `AbstractOutput::name()` to `AbstractOutput::description()` to keep `AbstractOutput::name()` and `XdgOutputInterface::name()` in sync.

I had looked. Without bringing in further behavioural changes it makes things worse.

You then need to change screens to be in sync, and that one gets used a lot.

Then instead of having one piece of code refer to name when they mean description, we have dozens refer to description when they just want a simple readable name.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28230

To: davidedmundson, #kwin, #plasma
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200324/48bb0921/attachment-0001.html>


More information about the kwin mailing list