D28085: Adapt to new KScreenLocker API

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Shall I put the connects in the constructor to move this forward?
  
  You choose.

INLINE COMMENTS

> romangg wrote in wayland_server.cpp:578
> When the client goes down libwayland calls into the client connection destroy callback and that deletes the client here:
> https://cgit.kde.org/kwayland.git/tree/src/server/clientconnection.cpp#n61
> 
> At this point trying to delete the connection from KWin's side would be a double-free.
> 
> If you think this API is not so intuitive don't look in the Client lib. :)

I don't like that client API :/

But this code makes sense then.

REPOSITORY
  R108 KWin

BRANCH
  kwin-fd-only

REVISION DETAIL
  https://phabricator.kde.org/D28085

To: romangg, #kwin, davidedmundson
Cc: davidedmundson, apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200323/71f9388c/attachment.html>