D28152: [RFC] KWinRules KCM Redesign

Ismael Asensio noreply at phabricator.kde.org
Sun Mar 22 00:22:39 GMT 2020


iasensio added inline comments.

INLINE COMMENTS

> broulik wrote in rulesmodel.cpp:773
> There's now a `KSortFilterProxyModel` in `KItemModels` you can use from QML for simple filtering like this. Just a suggestion.

That seems very handy. I've been trying to, but apparently there is no way to `invalidateFilter()` from the QML side, to add the `showAll` condition.
Maybe can it be extended on `KItemModels`?

> broulik wrote in rulesmodel.cpp:775
> I probably would have stored the search string in a member and done the filtering fully custom here rather than relying on `filterFixedString`

Added fully custom search, to include `name` and `value` properties

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28152

To: iasensio, #plasma, #kwin, #vdg
Cc: hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200322/c6766367/attachment-0001.html>


More information about the kwin mailing list