D27784: KCM KWinTabBox manage KCModule states

Vlad Zahorodnii noreply at phabricator.kde.org
Thu Mar 19 12:56:06 GMT 2020


zzag added inline comments.

INLINE COMMENTS

> main.cpp:420-422
> +    KWinTabBoxConfigForm *form = nullptr;
> +    QObject *ancestor = sender();
> +    form = qobject_cast<KWinTabBoxConfigForm *>(ancestor);

Could we maybe drop `ancestor`? e.g.

  auto form = qobject_cast<KWinTabBoxConfigForm *>(sender());

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27784

To: crossi, #kwin, ervin, bport, meven, zzag
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200319/f7b3593b/attachment-0001.html>


More information about the kwin mailing list