D27861: WIP: Rework xdg-shell implementation

[Anthony Fieroni]

anthonyfieroni added a comment.


  > Because KWayland is a KF library,
  >  we are not able to change existing API in ways that may break API or
  >  ABI compatibility. So, if some particular wrapper has been implemented
  >  incorrectly, we can't do that much about it except maybe leaving
  >  comments that look like "// TODO KF6".
  
  My 2 cents on this, that's normal implementation dependant situation in library, so about me it has 2 approaches:
  
  1. Always adds new required implementation in new class, then port existing users on it, leave orphaned classes to be removed
  2. To not break API/ABI it can be added a constructor by dependency injection the new implementation. It's a bit tricky, KTextEditor uses it, but it's not that bad.
  
  Returning implementation to the client can be good if it's not expected any other client(s) to use it, if not that's not good.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27861

To: zzag, #kwin
Cc: anthonyfieroni, univerz, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200319/21b846ab/attachment-0001.html>