D28101: [Toplevel] Check info being null

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Mar 17 14:41:50 GMT 2020


broulik created this revision.
broulik added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
broulik requested review of this revision.

REVISION SUMMARY
  There's some X11-reliance in `Toplevel` which is ideally split out but for now let's check for `info` being null.
  For instance, accessing `pid()` on a deleted Wayland client can crash when it's no longer a `XdgShellClient`.

TEST PLAN
  - Had an effect that called `EffectWindow->pid()` in `windowDeleted`. No longer crashes now

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28101

AFFECTED FILES
  toplevel.cpp

To: broulik, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200317/60672a1b/attachment.html>


More information about the kwin mailing list