D28062: Fix compiler warnings

Vlad Zahorodnii noreply at phabricator.kde.org
Tue Mar 17 13:35:07 GMT 2020


zzag added inline comments.

INLINE COMMENTS

> showfps.cpp:126
>  {
> -    if (time == 0) {
> -        // TODO optimized away
> -    }
> -    t.start();
> -    frames[ frames_pos ] = t.minute() * 60000 + t.second() * 1000 + t.msec();
> +    bool wasRunning = t.isValid();
> +    frames[ frames_pos ] = t.restart();

`wasRunning` is unused.

> main_wayland.cpp:262-263
>          });
> -        p->start(m_sessionArgument);
> +        p->setProgram(m_sessionArgument);
> +        p->start();
>      }

Could you please walk me through this change? Why do we need to call setProgram()?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28062

To: apol, #kwin
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200317/660bcea3/attachment.html>


More information about the kwin mailing list