D27861: WIP: Rework xdg-shell implementation

[David Edmundson]

davidedmundson added a comment.


  Seems like a no-brainer then.
  
  It means this patch tells a nicer story. We're getting rid of all abstraction now there's one stable thing and we can rely on everything using that.
  
  There's a bit to follow up on the ML wrt the protocol location.  Then we can do start a code review.

INLINE COMMENTS

> zzag wrote in xdgshellclient_test.cpp:1417
> Urgh, I made a mistake in the window geometry patch series.
> 
> The current window geometry is QRect(10, 10, 180, 80) and the current bounding rect is QRect(0, 0, 100, 50). Their intersection produces QRect(10, 10, 90, 40).

why is it only coming up now?

The change in placement.cpp?

Can they be standalone?

> xdgshellv6interface.cpp:736
> +    // choice because this means that one can set an anchor with opposite edges, which doesn't
> +    // make any sense. Luckily for us, this is not the case in xdg_wm_base!
> +

Not luck, I was the one who changed WMBase for that very reason, glad you agree \o/

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27861

To: zzag, #kwin
Cc: univerz, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200317/014d9a89/attachment.html>