D27988: KCM/Compositing: Use KConfig XT in UI

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> zzag wrote in main.cpp:88
> We don't capture any variable so there is no point for using a lambda.

Well, this is captured because of m_settings, isn't it?

It would be nice to have this as third connect parameter though.

> main.cpp:158
>      // windowThumbnail
> -    m_form.windowThumbnail->setCurrentIndex(m_compositing->windowThumbnail());
> -    connect(m_compositing, &Compositing::windowThumbnailChanged, m_form.windowThumbnail, &QComboBox::setCurrentIndex);
> -    connect(m_form.windowThumbnail, currentIndexChangedSignal, m_compositing, &Compositing::setWindowThumbnail);
> -    connect(m_form.windowThumbnail, currentIndexChangedSignal,
> +    connect(m_form.kcfg_HiddenPreviews, currentIndexChangedSignal,
>          [this](int index) {

Please add this as third connect parameter

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27988

To: meven, #kwin, ervin, crossi, bport, hchain
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200316/2909b042/attachment.html>