D27934: KCM/Kwinoptions: Port focus tab to KConfigXT

Vlad Zahorodnii noreply at phabricator.kde.org
Fri Mar 13 09:44:45 GMT 2020


zzag added inline comments.

INLINE COMMENTS

> focus.ui:25
>         <property name="buddy">
> -        <cstring>windowFocusPolicyCombo</cstring>
> +        <cstring>unmanagedFocusPolicy</cstring>
>         </property>

I recommend to be very careful with the word "unmanaged" in kwin. We have a class called Unmanaged, which is used to represent override-redirect windows on X11.

What about renaming unamangedFocusPolicy to something else? e.g. windowFocusPolicy?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27934

To: meven, ervin, bport, hchain, crossi, #kwin
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200313/7bf1f384/attachment.html>


More information about the kwin mailing list