D27682: Port kwinrules kcm to kconfigxt

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> ruleslist.h:53
>  private:
> -    QVector< Rules* > rules;
> +    QVector< Rules* > m_rules;
> +    RuleBookSettings m_settings;

While you're on this, could you please fix coding style?

  QVector<Rules *> m_rules;

> rulebooksettings.cpp:27
> +    : RuleBookSettingsBase(config, parent)
> +    , m_list({})
> +{

Seems redundant. Please delete this line.

> rulebooksettings.h:31
> +class Rules;
> +// class RuleSettings;
> +

It appears like we can uncomment this line and remove include for RuleSettings.

> ervin wrote in rules.cpp:314
> `int v`, the const is mostly useless here

We no longer read rules here. Maybe rename this method to match what it does now?

> rules.h:389
>  
> -Q_DECLARE_OPERATORS_FOR_FLAGS(KWin::Rules::Types)
> +Q_DECLARE_OPERATORS_FOR_FLAGS(KWin::Rules::Types);
>  

Unrelated change. Please revert it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27682

To: hchain, meven, crossi, bport, ervin, #kwin
Cc: iasensio, ognarb, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200311/43fdfb07/attachment.html>