D27899: [wayland] Simplify output handling

Vlad Zahorodnii noreply at phabricator.kde.org
Tue Mar 10 17:18:28 GMT 2020


zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  This patch looks alright to me, but I don't feel confident about the part where we assume that deletion of the wl_output global won't corrupt the corresponding XdgOutputInterface object. It might bite us in the future.

INLINE COMMENTS

> abstract_wayland_output.cpp:46-48
> +            [this] (KWayland::Server::OutputInterface::DpmsMode mode) {
> +        updateDpms(mode);
> +    });

Hmm, we probably don't need a lambda here. &AbstractWaylandOutput::updateDpms should be fine.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27899

To: davidedmundson, #kwin, zzag
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200310/3a2b6ac1/attachment.html>


More information about the kwin mailing list