D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage

[Aleix Pol Gonzalez]

apol added a comment.


  In D27788#622423 <https://phabricator.kde.org/D27788#622423>, @zzag wrote:
  
  > I am not sure that the region passed to eglSetDamageRegionKHR is correct. The specified region indicates the area to which all rendering commands must be restricted. So, let's say that we need to repaint region A to repair the back buffer and region B is the damage region for the current(next?) frame. So, the resulting damage region which will be passed to eglSetDamageRegionKHR is defined as the union of region A and region B. Currently, we pass only the region that specifies what parts of the back buffer must be repaired. Am I missing something?
  >
  > I also would like to point out that we don't have control over how many buffers gbm allocates. So, we can't ignore buffer age when determining the area that must be repaired.
  
  
  You were right, I misused arc somehow and submitted a half-baked last version of the patch. I only realised now when I looked at it and saw that it still had code I had removed.
  
  Sorry about that.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27788

To: apol, #kwin, #plasma:_mobile
Cc: mwolff, zzag, davidedmundson, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200309/302ed224/attachment.html>