D27477: KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kwinoptions_settings.kcfg:65
> +            <choice name="Maximize"></choice>
> +            <choice name="Maximize_vertical_only" value="Maximize (vertical only)"></choice>
> +            <choice name="Maximize_horizontal_only" value="Maximize (horizontal only)"></choice>

Camel case (you camel cased the other similar ones)

> kwinoptions_settings.kcfg:66
> +            <choice name="Maximize_vertical_only" value="Maximize (vertical only)"></choice>
> +            <choice name="Maximize_horizontal_only" value="Maximize (horizontal only)"></choice>
> +            <choice name="Minimize"></choice>

Ditto

> main.cpp:210
>      mTitleBarActions->load();
> -    mWindowActions->load();
> -    emit KCModule::changed(false);

Sure about that?

> main.cpp:234
>      mTitleBarActions->defaults();
> -    mWindowActions->defaults();
> -

Sure about that?

(This comment and the previous one are due to you apparently reverting a past mistake but I wonder if you missed a bit of it)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27477

To: meven, crossi, bport, ervin, #kwin
Cc: zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200305/6a138b07/attachment-0001.html>