D27822: Introduce AbstractClient::createDecoration()

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Mar 4 11:45:01 GMT 2020


apol added a comment.


  +1 looks good!

INLINE COMMENTS

> abstract_client.cpp:2146
> +        connect(decoration, &KDecoration2::Decoration::shadowChanged, this, &Toplevel::updateShadow);
> +        connect(decoration, &KDecoration2::Decoration::bordersChanged, this, [this]() {
> +            GeometryUpdatesBlocker blocker(this);

We are not capturing anything, reads like it could be a normal slot.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27822

To: zzag, #kwin
Cc: apol, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200304/148ee98b/attachment-0001.html>


More information about the kwin mailing list