D27784: KCM KWinTabBox manage KCModule states

Méven Car noreply at phabricator.kde.org
Wed Mar 4 08:32:41 GMT 2020


meven added inline comments.

INLINE COMMENTS

> main.cpp:244
> +{
> +    connect(ui->effectConfigButton, SIGNAL(clicked(bool)), SLOT(configureEffectClicked()));
> +

Too bad we have to use old syntax for private slots

> main.cpp:450
>      } else {
> +        // For builtin effect, dispplay a configuration dialog
>          QPointer<QDialog> configDialog = new QDialog(this);

s/dispplay/display

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27784

To: crossi, #kwin, ervin, bport, meven, zzag
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200304/e69cbde6/attachment.html>


More information about the kwin mailing list