D27809: decorationbridge: Fix crash on plasma mobile

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> decorationbridge.cpp:314
>      QString b;
> +
>      b.append(QStringLiteral("Plugin: %1\n").arg(m_plugin));

I see a potential crash when decorations are disabled. Perhaps we need to check m_noPlugin, e.g.

  if (m_noPlugin) {
      b.append(QStringLiteral("Decorations are disabled"));
  } else {
      b.append(QStringLiteral("Plugin: %1\n").arg(m_plugin));
      b.append(QStringLiteral("Theme: %1\n").arg(m_theme));
      b.append(QStringLiteral("Plugin recommends border size: %1\n").arg(m_recommendedBorderSize.isNull() ? "No" : m_recommendedBorderSize));
      b.append(QStringLiteral("Blur: %1\n").arg(m_blur));
      const QMetaObject *metaOptions = m_settings->metaObject();
      for (int i=0; i<metaOptions->propertyCount(); ++i) {
          const QMetaProperty property = metaOptions->property(i);
          if (QLatin1String(property.name()) == QLatin1String("objectName")) {
              continue;
          }
          b.append(QStringLiteral("%1: %2\n").arg(property.name()).arg(settingsProperty(m_settings->property(property.name()))));
      }
  }

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27809

To: apol, #kwin
Cc: zzag, anthonyfieroni, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200303/0e675ec7/attachment.html>