D27682: Port kwinrules kcm to kconfigxt

Cyril Rossi noreply at phabricator.kde.org
Tue Mar 3 12:35:42 GMT 2020


crossi added inline comments.

INLINE COMMENTS

> rulebooksettings.cpp:1
> +#include "rulebooksettings.h"
> +

Please add copyright header.

> rulebooksettings.h:1
> +#ifndef RULEBOOKSETTINGS_H
> +#define RULEBOOKSETTINGS_H

Please add copyright header.

> rulebooksettings.kcfg:1
> +<?xml version="1.0" encoding="UTF-8"?>
> +<kcfg xmlns="http://www.kde.org/standards/kcfg/1.0" 

File should be named rulebooksettingsbase.kcfg

> rulebooksettingsbase.kcfgc:1
> +File=rulebooksettings.kcfg
> +NameSpace=KWin

File should be named rulebooksettingsbase.kcfg

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27682

To: hchain, meven, crossi, bport, ervin, #kwin
Cc: ognarb, zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200303/5343cbdf/attachment.html>


More information about the kwin mailing list