D27789: [autotests] Fix failing KeyboardLayoutTest::testNumLock()
Vlad Zahorodnii
noreply at phabricator.kde.org
Mon Mar 2 16:40:18 GMT 2020
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.
REVISION SUMMARY
Since Qt::KeypadModifier is set only for keypad keys and not the NumLock
key, we need to press at least one keypad key to determine whether
numlock is actually on. On the other hand, we know that when numlock is
on, the corresponding LED is also on. So we could check the LED rather
than press two keys.
TEST PLAN
testKeyboardLayout passes.
REPOSITORY
R108 KWin
BRANCH
check-led-status-in-test-num-lock
REVISION DETAIL
https://phabricator.kde.org/D27789
AFFECTED FILES
autotests/integration/keyboard_layout_test.cpp
To: zzag, #kwin
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200302/e043b80a/attachment.html>
More information about the kwin
mailing list