D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation

Vlad Zahorodnii noreply at phabricator.kde.org
Thu Jun 11 10:02:43 BST 2020


zzag added a comment.


  In general, +1. I'm not certain about what a better place to put the new service utilities is, though. Perhaps it's better to move them to libkwineffects or something. Either way, it can be revisited later...

INLINE COMMENTS

> service_utils.h:38
> +
> +Q_DECLARE_LOGGING_CATEGORY(KWIN_CORE)
> +namespace KWin

We're going to use wrong logging caterogy if code below is invoked from the screenshot effect.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29407

To: meven, #kwin, apol, davidedmundson, bport, zzag
Cc: ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200611/c4cafc06/attachment.htm>


More information about the kwin mailing list