D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation
Méven Car
noreply at phabricator.kde.org
Mon Jun 8 14:43:08 BST 2020
meven added inline comments.
INLINE COMMENTS
> service_utils.h:48
> + const auto servicesFound = KApplicationTrader::query([&executablePath] (const KService::Ptr &service) {
> + if (service->exec().isEmpty() || service->exec() != executablePath)
> + return false;
We might want to tolerate non-absolute path for simplicity provided the exe are first in path.
Pseudo code :
if (!service->exec()->isAbsolute() {
exec = QStandardPaths::findExecutable(service->exec())
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D29407
To: meven, #kwin, apol, davidedmundson, bport, zzag
Cc: ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200608/c07a8f62/attachment.htm>
More information about the kwin
mailing list