D27050: Use QRect::moveRight() and QRect::moveBottom() in XdgShellClient::transientPlacement()

[David Edmundson]

davidedmundson added a comment.


  or to rephrase zzag:
  
  .right() is off by one
  .setRight is off by one
  
  so it cancels out.
  
  Personally I find it so difficult to parse that it's easier to just boycott the method. 
  Everyone who comes across it and is aware of QRect's ridiculousness ends up having to do a load of additional checking in their heads anyway.
  
  Though we don't have a kwin policy on that and we use QRect::right/bottom in other places, so I can't have a formal objection here.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27050

To: zzag, #kwin
Cc: davidedmundson, broulik, kwin, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200131/5a641c54/attachment-0001.html>