D26859: Implement the tablet wayland protocol in kwin

Vlad Zahorodnii noreply at phabricator.kde.org
Tue Jan 28 11:01:45 GMT 2020


zzag accepted this revision.
zzag added a subscriber: davidedmundson.
zzag added a comment.
This revision is now accepted and ready to land.


  Code-wise, +1
  
  Please wait for a +1 from @davidedmundson

INLINE COMMENTS

> input.cpp:1554
> +
> +    void integrateDevice(LibInput::Device *device)
> +    {

Naming nitpick: maybe `addDevice`?

> input_event.h:193
> +    quint64 serialId() const { return m_serialId; }
> +    QString tabletSysName() { return m_tabletSysName; }
> +

Make it `const`?

REPOSITORY
  R108 KWin

BRANCH
  apol/tablet-unstable-v2-1

REVISION DETAIL
  https://phabricator.kde.org/D26859

To: apol, #kwin, #plasma, zzag
Cc: davidedmundson, zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200128/547b6840/attachment-0001.html>


More information about the kwin mailing list