D25904: [libkwineffects] Set original backend framebuffer for render targets

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> fredrik wrote in kwinglutils.cpp:1091
> No, the idea is that whoever calls setKWinFramebuffer() would also call setDefaultViewport() to define the viewport that should be used when that framebuffer is bound.
> 
> Right now pushRenderTarget() queries GL_VIEWPORT so popRenderTarget() can restore it when the last custom render target is popped. But if we already know what the viewport should be, we don't have to query it from the GL.

So this is a performance optimization but without this it shouldn't break, correct? Let's put it then in a separate patch.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25904

To: romangg, #kwin
Cc: fredrik, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200107/e3cd9e3b/attachment-0001.html>