D27682: Port kwinrules kcm to kconfigxt

Vlad Zahorodnii noreply at phabricator.kde.org
Thu Feb 27 12:41:34 GMT 2020


zzag added inline comments.

INLINE COMMENTS

> ervin wrote in rulesettingsmanager.h:1
> Looks like those include guards should be changed to match the filename, and please rename that to rulesettings.h (+ rulesettings.cpp) of course.

FWIW, we (KWin devs) are okay with using `#pragma once`.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27682

To: hchain, meven, crossi, bport, ervin, #kwin
Cc: zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200227/8f41a884/attachment.html>


More information about the kwin mailing list