D27339: Implement input methods

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> apol wrote in xdgshellclient.cpp:89-91
> it's just an interface that provides us a surface and some information on how to place it on the screen.

I'm a little bit concerned about the case where one wants to get a zwp_input_panel_surface_v1 for a wl_surface which is also an xdg_toplevel or xdg_popup. In that case, the wl_surface will be represented by two XdgShellClient objects!

Perhaps we need to install an InputPanelSurfaceInterface rather than create a new XdgShellClient for it. For what it's worth, that's how we handle plasma surfaces (org_kde_plasma_surface).

  void XdgShellClient::installInputPanelSurface(InputPanelSurfaceInterface *surface)
  {
      m_inputPanelSurface = surface;
  
      // a bunch of connects
  }

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27339

To: apol, #kwin
Cc: zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200213/914c26b9/attachment-0001.html>