D27323: KCM KWinTabBox port to KConfigXT : use generated kcfg settings to load and save config

[Vlad Zahorodnii]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  +1

INLINE COMMENTS

> main.h:73-74
>  private:
> -    void updateUiFromConfig(KWinTabBoxConfigForm* ui, const TabBox::TabBoxConfig& config);
> -    void updateConfigFromUi(const KWinTabBoxConfigForm* ui, TabBox::TabBoxConfig& config);
> -    void loadConfig(const KConfigGroup& config, KWin::TabBox::TabBoxConfig& tabBoxConfig);
> -    void saveConfig(KConfigGroup& config, const KWin::TabBox::TabBoxConfig& tabBoxConfig);
> +    void updateUiFromConfig(KWinTabBoxConfigForm* ui, const TabBox::TabBoxSettings& config);
> +    void updateConfigFromUi(const KWinTabBoxConfigForm* ui, TabBox::TabBoxSettings& config);
>      void initLayoutLists();

Minor nitpick: it seems like there's no any reason to pass `config` by reference now. At each call site, we de-reference a settings object. I suggest to pass `config` by pointer.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27323

To: crossi, ervin, bport, meven, #kwin, zzag
Cc: zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200211/c001f7b5/attachment.html>