D27171: kcms/kwinoptions : convert Advanced part to KConfigXT

Méven Car noreply at phabricator.kde.org
Thu Feb 6 08:06:37 GMT 2020


meven added inline comments.

INLINE COMMENTS

> windows.cpp:364
>  
> -void KAdvancedConfig::shadeHoverChanged(bool a)
> -{
> -    m_ui->shadeHover->setEnabled(a);
> +    m_ui->kcfg_Placement->setItemData(KWinOptionsSettings::PlacementChoices::Smart, "Smart");
> +    m_ui->kcfg_Placement->setItemData(KWinOptionsSettings::PlacementChoices::Maximizing, "Maximizing");

I wish we had a way to have the enum's user label in kcfg files

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27171

To: meven, ervin, #kwin, bport, crossi, zzag
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200206/4dece6d0/attachment.html>


More information about the kwin mailing list