D27164: kcms/kwinoptions : convert Moving part to KConfigXT

Vlad Zahorodnii noreply at phabricator.kde.org
Wed Feb 5 10:55:50 GMT 2020


zzag added a comment.


  Good stuff.

INLINE COMMENTS

> kwinoptions_settings.kcfg:13-23
> +    <entry key="BorderSnapZone" type="Int">
> +        <default>10</default>
> +    </entry>
> +
> +    <entry key="WindowSnapZone" type="Int">
> +        <default>10</default>
> +    </entry>

`<min/>` and `<max/>` values are missing.

> windows.cpp:514
>      if (standAlone) {
> -        config->sync();
> +        //config->sync();
>          // Send signal to all kwin instances

Please don't commit commented code unless there is a reason, in which case the reason must be stated in a comment or something.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27164

To: meven, ervin, #kwin
Cc: zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200205/11266e4d/attachment.html>


More information about the kwin mailing list