D27162: Make support for full screen mode optional

Vlad Zahorodnii noreply at phabricator.kde.org
Wed Feb 5 09:09:16 GMT 2020


zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  In long term, we want to split XdgShellClient into several classes. One
  class for xdg-toplevel clients, and the other one for xdg-popup clients.
  
  xdg-popup clients are much simpler than xdg-toplevel clients, they can't
  be maximized or shown in full screen mode, they can't be interactively
  moved on the screen, and so on. In the end, we will have to plumb many
  pure virtual methods, which looks a bit ugly.
  
  This change makes support for full screen mode in AbstractClient optional
  so we don't have to add those no-op methods and keep code more or less
  "clean."

TEST PLAN
  Compiles.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27162

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  internal_client.cpp
  internal_client.h

To: zzag, #kwin
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200205/f02e3ca2/attachment.html>


More information about the kwin mailing list