D27114: ScreenEdge: Do not use localtime for measuring duration

Arjen Hiemstra noreply at phabricator.kde.org
Mon Feb 3 00:19:54 GMT 2020


ahiemstra created this revision.
ahiemstra added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
ahiemstra requested review of this revision.

REVISION SUMMARY
  QDateTime::fromMSecSinceEpoch uses Qt::LocalTime by default. This involves an
  expensive localtime conversion. So instead force things to use UTC, as there
  is no need for timezone information when tracking durations.
  
  This is especially noticeable on Bedrock Linux, which uses a Fuse mounted
  /etc, which is slower than a plain /etc and causes quite some slowdown there.
  See https://github.com/bedrocklinux/bedrocklinux-userland/issues/140 for
  details.

TEST PLAN
  The screenedge unit test still passes.

REPOSITORY
  R108 KWin

BRANCH
  dont-use-localtime

REVISION DETAIL
  https://phabricator.kde.org/D27114

AFFECTED FILES
  plugins/platforms/x11/standalone/screenedges_filter.cpp
  screenedge.cpp
  tabbox/x11_filter.cpp

To: ahiemstra, #kwin
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200203/0451e2fe/attachment.html>


More information about the kwin mailing list