D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage

[Vlad Zahorodnii]

zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> zzag wrote in egl_gbm_backend.cpp:465
> `damagedRegion` contains the region that will be repainted in the next frame, so we don't need to accumulate surface damages again.
> 
> I suppose we want something like
> 
>   const QRegion region = damagedRegion & output.output->geometry();

This comment hasn't been addressed.

> apol wrote in egl_gbm_backend.cpp:529-541
> I think next person who reads the code will prefer to see it encapsulated.

Currently pendingDamageRegions() is used only in two places - aboutToStartPainting() and prepareRenderingForScreen(). There is no reason to accumulate surface damages _again_ in aboutToStartPainting().

After the second usage of pendingDamageRegions() is dropped, the introduction of pendingDamageRegions() will look unrelated.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27788

To: apol, #kwin, #plasma:_mobile, zzag
Cc: mwolff, zzag, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200429/d71a26b8/attachment.html>